[Mesa-dev] [PATCH v2 06/28] glsl: Add double builtin type

Pohjolainen, Topi topi.pohjolainen at intel.com
Fri Feb 6 00:29:34 PST 2015


On Fri, Feb 06, 2015 at 10:04:13AM +0200, Pohjolainen, Topi wrote:
> On Thu, Feb 05, 2015 at 11:56:28PM -0500, Ilia Mirkin wrote:
> > From: Dave Airlie <airlied at gmail.com>
> > 
> > This causes a lot of warnings about unchecked type in
> > switch statements - fix them later.
> 
> The rest of the series fixes things in the compiler frontend but leaves
> a lot unchecked in the compiler backend (at least in i965). Also we now
> get complains in NIR.
> Putting something intermediate to silence things that get fixed by the
> series itself probably doesn't make sense but I wonder if we should
> address NIR at least. Thoughts?

Furthermore this patch introduces warnings in the uniform module test that
are not fixed by the rest of the series either:

tests/uniform_initializer_utils.cpp: In function 'void generate_data_element(void*, const glsl_type*, ir_constant*&, unsigned int)':
tests/uniform_initializer_utils.cpp:83:14: warning: enumeration value 'GLSL_TYPE_DOUBLE' not handled in switch [-Wswitch]
       switch (type->base_type) {
              ^
tests/uniform_initializer_utils.cpp:83:14: warning: enumeration value 'GLSL_TYPE_IMAGE' not handled in switch [-Wswitch]
tests/uniform_initializer_utils.cpp:111:14: warning: enumeration value 'GLSL_TYPE_DOUBLE' not handled in switch [-Wswitch]
       switch (type->base_type) {
              ^
tests/uniform_initializer_utils.cpp:111:14: warning: enumeration value 'GLSL_TYPE_IMAGE' not handled in switch [-Wswitch]
tests/uniform_initializer_utils.cpp: In function 'void verify_data(gl_constant_value*, unsigned int, ir_constant*, unsigned int, unsigned int)':
tests/uniform_initializer_utils.cpp:211:10: warning: enumeration value 'GLSL_TYPE_DOUBLE' not handled in switch [-Wswitch]
   switch (val->type->base_type) {
          ^
tests/uniform_initializer_utils.cpp:211:10: warning: enumeration value 'GLSL_TYPE_IMAGE' not handled in switch [-Wswitch]



More information about the mesa-dev mailing list