[Mesa-dev] [PATCH 4/4] drirc: add workarounds for Unigine Sanctuary v2

[Ian Romanick]

On 02/04/2015 02:18 AM, Matt Turner wrote:
> On Tue, Feb 3, 2015 at 7:41 AM, Martin Peres
> <martin.peres at linux.intel.com> wrote:
>> v2:
>> - rename mesa_extension-override to extension_override
>> - improve the comment by telling we disable GL_ARB_gpu_shader5 (Ilia)
>> - fix the name ARB_GL_gpu_shader5 to GL_ARB_gpu_shader5 (Ilia)
>>
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=82897
>> Signed-off-by: Martin Peres <martin.peres at linux.intel.com>
>> ---
>>  src/mesa/drivers/dri/common/drirc | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
>> diff --git a/src/mesa/drivers/dri/common/drirc b/src/mesa/drivers/dri/common/drirc
>> index 10c60d5..8d59e61 100644
>> --- a/src/mesa/drivers/dri/common/drirc
>> +++ b/src/mesa/drivers/dri/common/drirc
>> @@ -10,6 +10,12 @@ Application bugs worked around in this file:
>>    Enabling all extensions for Unigine fixes most issues, but the GLSL version
>>    is still 1.10.
>>
>> +* Unigine Sanctuary 2.3 makes use of the "sample" keyword which is reserved
>> +  with GL_ARB_gpu_shader5 which got enabled by force_glsl_extensions_warn.
> 
> It doesn't make use of the sample keyword, it just has a variable
> named "sample" which has now become a keyword, right?
> 
> How about
> 
> <Application> uses "sample" as a variable name which is a keyword as
> of GL_ARB_gpu_shader5. GL_ARB_gpu_shader5 is enabled by
> force_glsl_extensions_warn.

I like that suggestion.

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

> The same comment applies to 3/4.
> 
> With the comment updated, 3 and 4 are
> 
> Reviewed-by: Matt Turner <mattst88 at gmail.com>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>