[Mesa-dev] [PATCH 18/32] i965/vec4: Don't attempt to reduce swizzles of send from GRF instructions.

Matt Turner mattst88 at gmail.com
Fri Feb 6 13:08:39 PST 2015


On Fri, Feb 6, 2015 at 6:42 AM, Francisco Jerez <currojerez at riseup.net> wrote:
> ---
>  src/mesa/drivers/dri/i965/brw_vec4.cpp | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_vec4.cpp b/src/mesa/drivers/dri/i965/brw_vec4.cpp
> index c3f68e6..aaa4873 100644
> --- a/src/mesa/drivers/dri/i965/brw_vec4.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_vec4.cpp
> @@ -437,7 +437,8 @@ vec4_visitor::opt_reduce_swizzle()
>     bool progress = false;
>
>     foreach_block_and_inst_safe(block, vec4_instruction, inst, cfg) {
> -      if (inst->dst.file == BAD_FILE || inst->dst.file == HW_REG)
> +      if (inst->dst.file == BAD_FILE || inst->dst.file == HW_REG ||
> +          inst->is_send_from_grf())
>           continue;
>
>        int swizzle[4];
> --
> 2.1.3

Like the last patch, I totally believe this is a problem, I just want
a little more explanation for how it was uncovered.


More information about the mesa-dev mailing list