[Mesa-dev] [PATCH 1/3] util/hash_table: Do a full search when adding new items
eric at anholt.net
Fri Feb 6 20:34:37 PST 2015
Jason Ekstrand <jason at jlekstrand.net> writes:
> Previously, the hash_table_insert function would bail early if it found a
> deleted slot that it could re-use. However, this is a problem if the key
> being inserted is already in the hash table but further down the list. If
> this happens, the element ends up getting inserted in the hash table twice.
> This commit makes it so that we walk over all of the possible entries for
> the given key and then, if we don't find the key, place it in the available
> free entry we found.
Actually, I shouldn't block sending my review on upstreaming to the
other repo. Series is:
Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 818 bytes
Desc: not available
More information about the mesa-dev