[Mesa-dev] [PATCH 04/10] i965/cfg: Add function to generate a dot file of the dominator tree.

Matt Turner mattst88 at gmail.com
Mon Feb 9 18:03:09 PST 2015


On Mon, Feb 9, 2015 at 5:54 PM, Kenneth Graunke <kenneth at whitecape.org> wrote:
> On Wednesday, February 04, 2015 08:21:21 PM Matt Turner wrote:
>> ---
>>  src/mesa/drivers/dri/i965/brw_cfg.cpp | 10 ++++++++++
>>  src/mesa/drivers/dri/i965/brw_cfg.h   |  1 +
>>  2 files changed, 11 insertions(+)
>>
>> diff --git a/src/mesa/drivers/dri/i965/brw_cfg.cpp b/src/mesa/drivers/dri/i965/brw_cfg.cpp
>> index 2d6a181..095c34f 100644
>> --- a/src/mesa/drivers/dri/i965/brw_cfg.cpp
>> +++ b/src/mesa/drivers/dri/i965/brw_cfg.cpp
>> @@ -504,3 +504,13 @@ cfg_t::dump_cfg()
>>     }
>>     printf("}\n");
>>  }
>> +
>> +void
>> +cfg_t::dump_domtree()
>> +{
>> +   printf("digraph CFG {\n");
>
> Shouldn't this be "digraph domtree" or such?  Looks like "digraph CFG"
> got copy and pasted from the previous patch.
>
> Patches 1, 3-5 are:
> Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

I don't really know much about the dot format. I think that argument
shows up as the title of the document. I'll change it.

Thanks!


More information about the mesa-dev mailing list