[Mesa-dev] Re: [PATCH] st/nine: Mark end of non-void function unreachable

Tobias Klausmann tobias.johannes.klausmann at mni.thm.de
Mon Feb 9 19:54:26 PST 2015


Right, the function isn't even defined in that scope, tired me shouldn't 
even try to write code ;-)

On 10.02.2015 04:48, Jan Vesely wrote:
> On Tue, 2015-02-10 at 04:43 +0100, Tobias Klausmann wrote:
>> Signed-off-by: Tobias Klausmann <tobias.johannes.klausmann at mni.thm.de>
>> ---
>>   src/gallium/state_trackers/nine/nine_pipe.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/gallium/state_trackers/nine/nine_pipe.h b/src/gallium/state_trackers/nine/nine_pipe.h
>> index 17844d5..3480aad 100644
>> --- a/src/gallium/state_trackers/nine/nine_pipe.h
>> +++ b/src/gallium/state_trackers/nine/nine_pipe.h
>> @@ -222,7 +222,7 @@ d3d9_get_pipe_depth_format_bindings(D3DFORMAT format)
>>       case D3DFMT_DF24:
>>       case D3DFMT_INTZ:
>>           return PIPE_BIND_DEPTH_STENCIL | PIPE_BIND_SAMPLER_VIEW;
>> -    default: assert(0);
>> +    default: unreachable(0);
> Isn't unreachable supposed to use a string instead of 0?
>
>>       }
>>   }
>>   
>



More information about the mesa-dev mailing list