[Mesa-dev] [PATCH 3/4] configure: rework wayland_scanner handling(fix make distcheck)
emil.l.velikov at gmail.com
Tue Feb 10 14:18:43 PST 2015
On 10/02/15 18:23, Matt Turner wrote:
> On Tue, Feb 10, 2015 at 8:08 AM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>> Currently having the wayland-scanner is optional, which causes problems
>> when autotools parses through the makefiles, and tries to generate all
>> the BUILT_SOURCES.
>> As the config option --with-egl-platform=wayland is not the default, we
>> won't end up setting the WAYLAND_SCANNER variable, which in turn will
>> cause some files to not get generated.
>> There has been a wayland-scanner package as of wayland 1.2 which
>> provides a variable for the scanner binary, so let's use that one and
>> fall back to manually searching via AC_PATH_PROG when needed.
> Effectively this is just allowing you to avoid passing
> --with-egl-platform=wayland when building the tarball, but doesn't
> change the fact that you still need wayland on the machine?
Indeed it does not change that fact. I think that this is a bit hacky
solution, so if anyone has some input I'm all ears.
> I wouldn't have really thought that was useful, but if you do have a
> Reviewed-by: Matt Turner <mattst88 at gmail.com>
> (for patches 1 and 2 as well)
> I'm not familiar with the situation around patch 4.
> Thanks Emil! I'm really happy to see that we're going to be making a
> release with autotools distribution mechanism for once :)
Thanks. Hopefully this will make things a bit easier (more normal) for
the *BSD folk and they'll send patches to mesa a bit more often :-)
More information about the mesa-dev