[Mesa-dev] [Mesa-stable] [PATCH] configure: don't try to build gallium DRI drivers if --disable-dri is set

[Emil Velikov]

On 10/02/15 23:40, Brian Paul wrote:
> On 02/10/2015 04:24 PM, Emil Velikov wrote:
>> On 10/02/15 16:32, Brian Paul wrote:
>>> Before, if --disable-dri was set we were still testing the libdrm
>>> version
>>> for r300, r600, vmware/svga.
>>>
>> Fwiw there is no libdrm* check for vmware/svga.
> 
> Right, but if --disable-dri is given, we shouldn't build any drivers
> that use DRI.
> 
Imho there is a bit of ambiguity with {en,dis}able-dri. Is that the dri
modules, or the DRI{1,2,3,SW} infrastructure ? I'm inclined to go with
the former.

> 
>>
>> Your concern is that as you pass --disable-dri, you still get an error
>> about missing libdrm_radeon dependency ?
> 
> The issue was reported on mesa-users and I reproduced it here.
> 
> See
> http://lists.freedesktop.org/archives/mesa-users/2015-February/000920.html
> 
> 
>>
>> Afaics currently we disable all classic drivers with --disable-dri -
>> would you really want to build gallium swrast ?
> 
> I think building gallium softpipe/llvmpipe is what you'd expect if
> --disable-dri is given.
> 
Might I suggest that we drop swrast as well (similar to the classic
drivers) and feed swrast to --with-dri-drivers or --with-gallium-drivers
while keeping the other empty ?

This will give us enough flexibility, will "force" users to build what
they want. Plus it'll avoid the classic vs gallium swrast clash.


-Emil