[Mesa-dev] [PATCH 3/4] radeonsi: small fix in SPI state
Michel Dänzer
michel at daenzer.net
Wed Feb 11 23:15:23 PST 2015
On 11.02.2015 23:23, Marek Olšák wrote:
> From: Marek Olšák <marek.olsak at amd.com>
>
> Cc: 10.4 <mesa-stable at lists.freedesktop.org>
> ---
> src/gallium/drivers/radeonsi/si_state_shaders.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/src/gallium/drivers/radeonsi/si_state_shaders.c b/src/gallium/drivers/radeonsi/si_state_shaders.c
> index 27ccc8e..dea99ea 100644
> --- a/src/gallium/drivers/radeonsi/si_state_shaders.c
> +++ b/src/gallium/drivers/radeonsi/si_state_shaders.c
> @@ -662,8 +662,10 @@ bcolor:
> }
>
> if (j == vsinfo->num_outputs) {
> - /* No corresponding output found, load defaults into input */
> - tmp |= S_028644_OFFSET(0x20);
> + /* No corresponding output found, load defaults into input.
> + * Don't set any other bits.
> + * (FLAT_SHADE=1 completely changes behavior) */
> + tmp = S_028644_OFFSET(0x20);
> }
>
> si_pm4_set_reg(pm4,
>
Does this fix any known user visible bugs, or why the stable tag?
Patches 1 and 4 are
Reviewed-by: Michel Dänzer <michel.daenzer at amd.com>
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer
More information about the mesa-dev
mailing list