[Mesa-dev] [Bug 89068] glTexImage2D regression by texstore_rgba switch to _mesa_format_convert

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89068

--- Comment #9 from Iago Toral <itoral at igalia.com> ---
(In reply to Jason Ekstrand from comment #8)
> (In reply to Iago Toral from comment #7)
> > After testing with a binary provided by the reporter and comparing with the
> > old code it looks like the problem comes from the fact that they are using
> > transferOps for color scaling (which is effectively scaling 50% alpha values
> > to 100%)... and we are not dealing with that in texstore_rgba.
> > 
> > If we need to apply transferOps (we can call
> > _mesa_texstore_needs_transfer_ops to check this) then we have to convert
> > from the src format to RGBA_FLOAT, so we can call calling
> > mesa_apply_rgba_transfer_ops(), then convert the result from RGBA_FLOAT to
> > the dst format...
> > 
> > I think we should do this after we have handled swaping scenarios and before
> > the current call to _mesa_format_convert.
> 
> Sound good to me.  I'm kind of surprised piglit didn't catch that.

Yeah, me too. I'll try to write a pilgit test for this too.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150213/816f4ac7/attachment.html>