[Mesa-dev] [PATCH] i965/vec4: Override destination register writemask in sampler message send.

Matt Turner mattst88 at gmail.com
Fri Feb 13 08:44:58 PST 2015


On Fri, Feb 13, 2015 at 5:03 AM, Francisco Jerez <currojerez at riseup.net> wrote:
> This line was removed by accident in commit
> 16b911257440afbd77a6eb762e28df62e3c19bc7 causing a regression in the
> ES3-CTS.gtf.GL3Tests.shadow.shadow_execution_vert Khronos conformance
> test.  It's necessary because the swizzle_result() code below expects
> all four components of the vector to be valid.

Oh, huh. I think in fact I suggested you remove that line in my review. Oops.

Reviewed-by: Matt Turner <mattst88 at gmail.com>


More information about the mesa-dev mailing list