[Mesa-dev] [PATCH 5/5] i965/vec4: Silence unused parameter warnings

Ian Romanick idr at freedesktop.org
Fri Feb 13 13:36:03 PST 2015


On 02/13/2015 01:26 PM, Matt Turner wrote:
> On Fri, Feb 13, 2015 at 12:52 PM, Ian Romanick <idr at freedesktop.org> wrote:
>> From: Ian Romanick <ian.d.romanick at intel.com>
>>
>> brw_vec4_copy_propagation.cpp:243:59: warning: unused parameter 'reg' [-Wunused-parameter]
>>                     int arg, struct copy_entry *entry, int reg)
>>                                                            ^
> 
> Wow, just unused since it was added in commit 7841a246
> 
>>
>> brw_vec4_generator.cpp:869:57: warning: unused parameter 'inst' [-Wunused-parameter]
>>  vec4_generator::generate_unpack_flags(vec4_instruction *inst,
>>                                                          ^
> 
> And also unused since it was added in commit a9be50f7.
> 
> I'd love to know why we see different sets of warnings.

I have a bunch of extra warnings enabled.

-Wall -Wextra -Wunsafe-loop-optimizations -Werror=format-security

I think the unused parameter and unused variable warnings come from -Wextra.

> The series is
> 
> Reviewed-by: Matt Turner <mattst88 at gmail.com>



More information about the mesa-dev mailing list