[Mesa-dev] [PATCH] mesa: don't enable NV_fragment_program_option with swrast

[Roland Scheidegger]

Actually I think you can forget the second part of the comment. It seems
we still use some hacks internally to parse such shaders, even if they
aren't officially supported (though I don't know if they also relied on
the dropped opcodes). I guess though the NV_fragment_program_option in
the context could still go...

Roland

Am 14.02.2015 um 16:37 schrieb sroland at vmware.com:
> From: Roland Scheidegger <sroland at vmware.com>
> 
> Since dropping some NV_fragment_program opcodes (commits
> 868f95f1da74cf6dd7468cba1b56664aad585ccb, a3688d686f147f4252d19b298ae26d4ac72c2e08)
> we can no longer parse all opcodes necessary for this extension, leading
> to bugs (https://bugs.freedesktop.org/show_bug.cgi?id=86980).
> Hence don't announce support for it in swrast.
> (The rest of the infrastructure ranging from dead opcodes (TXP_NV) to
> parsing condition codes along with the NV_fragment_program_option variable
> in the context could probably nuked too this is just a minimal fix appropriate
> for stable too.)
> ---
>  src/mesa/main/extensions.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c
> index 220b220..c94009f 100644
> --- a/src/mesa/main/extensions.c
> +++ b/src/mesa/main/extensions.c
> @@ -511,7 +511,6 @@ _mesa_enable_sw_extensions(struct gl_context *ctx)
>     ctx->Extensions.NV_point_sprite = GL_TRUE;
>     ctx->Extensions.NV_texture_env_combine4 = GL_TRUE;
>     ctx->Extensions.NV_texture_rectangle = GL_TRUE;
> -   ctx->Extensions.NV_fragment_program_option = GL_TRUE;
>     ctx->Extensions.EXT_gpu_program_parameters = GL_TRUE;
>     ctx->Extensions.OES_standard_derivatives = GL_TRUE;
>     ctx->Extensions.TDFX_texture_compression_FXT1 = GL_TRUE;
>