[Mesa-dev] [PATCH v5 08/29] glsl: fix uniform linking logic in the presence of structs

[Dave Airlie]

On 17 February 2015 at 06:01, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
> On Tue, Feb 10, 2015 at 6:58 AM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
>> Add a enter/leave record callback so that the offset may be aligned to
>> the proper value. Otherwise only leaf fields are called, and the first
>> field needs to be aligned to the outer struct's base alignment while the
>> last field needs to be aligned to the inner struct's base alignment.
>>
>> This removes most usage of the last field/record type values passed into
>> visit_field.
>>
>> Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>

This seems like the correct solution, hopefully Ian can further examine this,
but it seems to fix the problems seen.

Reviewed-by: Dave Airlie <airlied at redhat.com>