[Mesa-dev] [PATCH 1/3] mesa: Add _mesa_has_compute_shaders

[Matt Turner]

On Tue, Feb 17, 2015 at 1:30 PM, Ben Widawsky
<benjamin.widawsky at intel.com> wrote:
> On Tue, Feb 17, 2015 at 11:37:44AM -0800, Ian Romanick wrote:
>> On 02/13/2015 11:02 PM, Ben Widawsky wrote:
>> > From: Jordan Justen <jordan.l.justen at intel.com>
>> >
>> > Signed-off-by: Jordan Justen <jordan.l.justen at intel.com>
>> > Reviewed-by: Ben Widawsky <ben at bwidawsk.net>
>> > ---
>> >  src/mesa/main/context.h | 11 +++++++++++
>> >  1 file changed, 11 insertions(+)
>> >
>> > diff --git a/src/mesa/main/context.h b/src/mesa/main/context.h
>> > index d902ea7..69389ae 100644
>> > --- a/src/mesa/main/context.h
>> > +++ b/src/mesa/main/context.h
>> > @@ -326,6 +326,17 @@ _mesa_has_geometry_shaders(const struct gl_context *ctx)
>> >  }
>> >
>> >
>> > +/**
>> > + * Checks if the context supports compute shaders.
>> > + */
>> > +static inline GLboolean
>>
>> bool
>>
>
> I don't mind changing this for Jordan before I push, but bool does seem
> inconsistent with the existing _mesa_has_foo. So long as you're aware...

Right.

Basically we've decided that we shouldn't use GL types for things that
aren't part of the GL API. No one has fixed all of the old uses of GL
types, but we don't want to add more. Removing all of the existing
uses would be nice, but kind of tedious.

It's inconsistent in the same way that adding code using spaces to a
file that (against convention ) contains tabs is inconsistent.