[Mesa-dev] [PATCH 2/2] i965/skl: Layout a 1D miptree horizontally

[Matt Turner]

On Wed, Feb 18, 2015 at 3:34 PM, Erik Faye-Lund <kusmabite at gmail.com> wrote:
> On Wed, Feb 18, 2015 at 6:02 PM, Ian Romanick <idr at freedesktop.org> wrote:
>> On 02/17/2015 06:03 AM, Neil Roberts wrote:
>>> +   /* When this layout is used the horizontal alignment is fixed at 64 and the
>>> +    * hardware ignores the value given in the surface state
>>> +    */
>>> +   const unsigned int align_w = 64;
>>> +
>>> +   mt->total_height = mt->physical_height0;
>>> +
>>> +   if (mt->compressed) {
>>> +      mt->total_height = ALIGN(mt->physical_height0, mt->align_h);
>>> +   }
>>
>> There aren't any compressed formats that support 1D textures, so I don't
>> think this can occur.  Does the bspec say anything about compressed 1D
>> textures?
>
> This might not be valid for this hardware generation, but ASTC
> supports compressed 1D textures...

I don't see that. It [0] mentions TexImage1D in an area that explains
what regular GL 4.2 allows but the next paragraph explains that it
doesn't apply to ASTC. I don't see text anywhere else that indicates
that 1D is supported. Am I looking at the wrong extension or missing
something?

[0] https://www.opengl.org/registry/specs/KHR/texture_compression_astc_hdr.txt