[Mesa-dev] [PATCH 2/2] st/mesa: add GSL_TYPE_DOUBLE, new ir_unop_* switch cases

Ilia Mirkin imirkin at alum.mit.edu
Thu Feb 19 12:23:19 PST 2015


On Thu, Feb 19, 2015 at 11:27 AM, Brian Paul <brianp at vmware.com> wrote:
> To silence compiler warnings about unhandled switch cases.
> ---
>  src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>
> diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
> index 3dac004..9969fac 100644
> --- a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
> +++ b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
> @@ -974,6 +974,7 @@ type_size(const struct glsl_type *type)
>     case GLSL_TYPE_UINT:
>     case GLSL_TYPE_INT:
>     case GLSL_TYPE_FLOAT:
> +   case GLSL_TYPE_DOUBLE:
>     case GLSL_TYPE_BOOL:
>        if (type->is_matrix()) {
>           return type->matrix_columns;

Both here and in the other patch, I'd rather you put this along with
the other "unexpected" types. The st/mesa patch will fix it up
properly -- double has more complex type_size() requirements.

  -ilia


More information about the mesa-dev mailing list