[Mesa-dev] [PATCH] gallium: add new double-related shader caps to all the getters

Ilia Mirkin imirkin at alum.mit.edu
Thu Feb 19 21:00:46 PST 2015


On Thu, Feb 19, 2015 at 11:54 PM, Dave Airlie <airlied at gmail.com> wrote:
> On 20 February 2015 at 14:46, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
>> Missed a few drivers in the earlier changes, this should fix up all the
>> ones that print unknown caps or don't have a default statement.
>>
>
>
>> +++ b/src/gallium/drivers/vc4/vc4_screen.c
>> @@ -318,6 +318,10 @@ vc4_screen_get_shader_param(struct pipe_screen *pscreen, unsigned shader,
>>                  return 1;
>>          case PIPE_SHADER_CAP_DOUBLES:
>>                  return 0;
>> +        case PIPE_SHADER_CAP_TGSI_DROUND_SUPPORTED:
>> +                return 0;
>> +        case PIPE_SHADER_CAP_TGSI_DFRACEXP_DLDEXP_SUPPORTED:
>> +                return 0;
>>          case PIPE_SHADER_CAP_MAX_TEXTURE_SAMPLERS:
>>          case PIPE_SHADER_CAP_MAX_SAMPLER_VIEWS:
>>                  return VC4_MAX_TEXTURE_SAMPLERS;
>
> Why does vc4 no collapse them into one return 0?

I dunno, they're mostly split up like that, I went with the flow.

>
> Otherwise:
> Reviewed-by: Dave Airlie <airlied at redhat.com>


More information about the mesa-dev mailing list