[Mesa-dev] [PATCH 2/2] r600g: add doubles support for CAYMAN

[Ilia Mirkin]

On Thu, Feb 19, 2015 at 9:59 PM, Glenn Kennard <glenn.kennard at gmail.com> wrote:
>> +       if ((write_mask & 0x3) != 0x3 &&
>> +           (write_mask & 0xc) != 0xc) {
>> +               fprintf(stderr, "illegal writemask for 64-bit: 0x%x\n",
>> write_mask);
>> +               return -1;
>> +       }

I think I noted this on IRC, but did you mean this to be || instead of
&& ? e.g. right now this will not trigger for a .xyz writemask, since
write_mask & 3 == 3.

BTW, this isn't a complete review, I was just scanning Glenn's
response and this happened to be below one of the lines he commented
on.

  -ilia