[Mesa-dev] [RFC] loader: not having a pci-id should not be a warn

[Ilia Mirkin]

On Sat, Feb 21, 2015 at 2:48 PM, Rob Clark <robdclark at gmail.com> wrote:
> From: Rob Clark <robclark at freedesktop.org>
>
> Lower this to an info message, to avoid confusing users.  Perhaps we
> should just drop this entirely.
> ---
> Anyone have any objection to this, or better suggestions?  Users are
> getting confused by this warning messange, and we do actually have
> non-PCI drivers these days ;-)

The pci_id is just null right? How about

pci_id == NULL ? _LOADER_INFO : _LOADER_WARNING

Since if it's misformatted or something, that's a much more serious issue.

>
>  src/loader/loader.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/loader/loader.c b/src/loader/loader.c
> index 94c993a..e9efa2e 100644
> --- a/src/loader/loader.c
> +++ b/src/loader/loader.c
> @@ -209,7 +209,7 @@ libudev_get_pci_id_for_fd(int fd, int *vendor_id, int *chip_id)
>     pci_id = udev_device_get_property_value(parent, "PCI_ID");
>     if (pci_id == NULL ||
>         sscanf(pci_id, "%x:%x", vendor_id, chip_id) != 2) {
> -      log_(_LOADER_WARNING, "MESA-LOADER: malformed or no PCI ID\n");
> +      log_(_LOADER_INFO, "MESA-LOADER: malformed or no PCI ID\n");
>        *chip_id = -1;
>        goto out;
>     }
> --
> 2.2.2
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev