[Mesa-dev] [PATCH 4/4] i965: Force miptrees for BOs to have all slices in each lod.

[Kenneth Graunke]

On Friday, February 20, 2015 01:30:56 PM Laura Ekstrand wrote:
> Textures made expressly for internal buffer objects shouldn't have extra
> padding around them, but should be densely packed.

I might explain this as:

PBOs do not support miplevels - array slices are densely packed, with no
extra padding.  We need to use the "Array Spacing LOD0" setting to make
our wrapper miptree have a QPitch value that matches the PBO's data
layout.

Nice find!

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

> ---
>  src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
> index 0e3888f..b46532d 100644
> --- a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
> +++ b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
> @@ -724,7 +724,7 @@ intel_miptree_create_for_bo(struct brw_context *brw,
>     mt = intel_miptree_create_layout(brw, target, format,
>                                      0, 0,
>                                      width, height, depth,
> -                                    true, 0, false);
> +                                    true, 0, true);
>     if (!mt) {
>        free(mt);
>        return mt;
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150223/aaaac919/attachment.sig>