[Mesa-dev] [PATCH 03/16] main: fix the validation of the number of samples

[Martin Peres]

On 20/02/15 20:57, Ilia Mirkin wrote:
> On Mon, Feb 16, 2015 at 9:13 AM, Martin Peres
> <martin.peres at linux.intel.com> wrote:
>> Maybe this should be the job of the dispatch layer.
>>
>> Signed-off-by: Martin Peres <martin.peres at linux.intel.com>
>> ---
>>   src/mesa/main/multisample.c | 9 +++++++++
>>   1 file changed, 9 insertions(+)
>>
>> diff --git a/src/mesa/main/multisample.c b/src/mesa/main/multisample.c
>> index 1f3fa0c..a0a659b 100644
>> --- a/src/mesa/main/multisample.c
>> +++ b/src/mesa/main/multisample.c
>> @@ -150,6 +150,15 @@ GLenum
>>   _mesa_check_sample_count(struct gl_context *ctx, GLenum target,
>>                            GLenum internalFormat, GLsizei samples)
>>   {
>> +   /* From the OpenGL core 3.0 spec, section 2.5:
> I think this is a bit of a contradiction... there is no OpenGL 3.0
> core spec. Core didn't become a thing until 3.1 afaik.
Indeed, the comment was about GL 4.5 and I updated to 3.0 without
getting rid of core.