[Mesa-dev] [PATCH 3/4] st/mesa: remove unused/broken function st_print_shaders

[Brian Paul]

On 02/24/2015 01:16 PM, Marek Olšák wrote:
> The function is pretty old. I don't know if anybody still needs it.
>
> Brian, what do you think about this patch?

I'm OK with removing it.  I haven't used it in a long time and I can 
always fish it out of git if I need it again.

-Brian

>
> There is a similar function that does more or less the same thing and
> is more explicit about gdb usage (st_debug.c):
>
> /**
>   * Print current state.  May be called from inside gdb to see currently
>   * bound vertex/fragment shaders and associated constants.
>   */
> void
> st_print_current(void)
>
> Marek
>
> On Tue, Feb 24, 2015 at 5:06 AM, Michel Dänzer <michel at daenzer.net> wrote:
>> On 24.02.2015 05:02, Marek Olšák wrote:
>>> From: Marek Olšák <marek.olsak at amd.com>
>>>
>>> ---
>>>   src/mesa/state_tracker/st_program.c | 45 -------------------------------------
>>>   src/mesa/state_tracker/st_program.h |  4 ----
>>>   2 files changed, 49 deletions(-)
>>>
>>> diff --git a/src/mesa/state_tracker/st_program.c b/src/mesa/state_tracker/st_program.c
>>> index ec123fb..744543f 100644
>>> --- a/src/mesa/state_tracker/st_program.c
>>> +++ b/src/mesa/state_tracker/st_program.c
>>> @@ -1219,51 +1219,6 @@ st_get_gp_variant(struct st_context *st,
>>>   }
>>>
>>>
>>> -
>>> -
>>> -/**
>>> - * Debug- print current shader text
>>> - */
>>> -void
>>> -st_print_shaders(struct gl_context *ctx)
>>
>> I think the idea is to be able to call this function from a debugger.
>>
>>
>> --
>> Earthling Michel Dänzer               |               https://urldefense.proofpoint.com/v2/url?u=http-3A__www.amd.com&d=AwIFaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=T0t4QG7chq2ZwJo6wilkFznRSFy-8uDKartPGbomVj8&m=LoZp-V4O30MRAvvjnbyUAG7D_cc8LD29EAoUOsiATqk&s=vKevzSHJdAckIcmZZ4H4aQ3KXY2Ij2AWKwleP19uHn8&e=
>> Libre software enthusiast             |             Mesa and X developer