[Mesa-dev] [PATCH 3/6 v2] i965/skl: Fix the qpitch value

Neil Roberts neil at linux.intel.com
Wed Feb 25 05:14:00 PST 2015

Ben Widawsky <ben at bwidawsk.net> writes:

>> +   if (layout_1d) {
>> +      physical_qpitch = mt->align_h;
>> +      /* When using the horizontal layout the qpitch is measured in pixels */
> I think the docs words are a bit clearer:
> "Surface QPitch specifies the distance in pixels between array
> slices."

Ok, yeah, I'll change it to that.

>> +      mt->qpitch = physical_qpitch * mt->total_width;
> talking to myself - this seems more complicated than it ought to be.

Maybe it would be less confusing if I changed it to
mt->align_h * mt->total_width?

> This patch is a bit trickier than the previous, and I got lazy with fact
> checking in bspec, but it lgtm:
> Reviewed-by: Ben Widawsky <ben at bwidawsk.net>

Thanks again for the reviews.

- Neil

More information about the mesa-dev mailing list