[Mesa-dev] [PATCH] meta: In pbo_{Get, }TexSubImage don't repeatedly rebind the source tex

[Jason Ekstrand]

Reviewed-by: Jason Ekstrand <jason.ekstrand at intel.com>

On Wed, Feb 25, 2015 at 8:02 AM, Neil Roberts <neil at linux.intel.com> wrote:

> A layered PBO image is now interpreted as a single tall 2D image so
> the z argument in _mesa_meta_bind_fbo_image is ignored. Therefore this
> was just redundantly rebinding the same image repeatedly.
> ---
>  src/mesa/drivers/common/meta_tex_subimage.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/src/mesa/drivers/common/meta_tex_subimage.c
> b/src/mesa/drivers/common/meta_tex_subimage.c
> index ffbbacd..407940a 100644
> --- a/src/mesa/drivers/common/meta_tex_subimage.c
> +++ b/src/mesa/drivers/common/meta_tex_subimage.c
> @@ -217,8 +217,6 @@ _mesa_meta_pbo_TexSubImage(struct gl_context *ctx,
> GLuint dims,
>             height : depth;
>
>     for (z = 1; z < iters; z++) {
> -      _mesa_meta_bind_fbo_image(GL_READ_FRAMEBUFFER, GL_COLOR_ATTACHMENT0,
> -                                pbo_tex_image, z);
>        _mesa_meta_bind_fbo_image(GL_DRAW_FRAMEBUFFER, GL_COLOR_ATTACHMENT0,
>                                  tex_image, zoffset + z);
>
> @@ -350,8 +348,6 @@ _mesa_meta_pbo_GetTexSubImage(struct gl_context *ctx,
> GLuint dims,
>     for (z = 1; z < iters; z++) {
>        _mesa_meta_bind_fbo_image(GL_READ_FRAMEBUFFER, GL_COLOR_ATTACHMENT0,
>                                  tex_image, zoffset + z);
> -      _mesa_meta_bind_fbo_image(GL_DRAW_FRAMEBUFFER, GL_COLOR_ATTACHMENT0,
> -                                pbo_tex_image, z);
>
>        _mesa_update_state(ctx);
>
> --
> 1.9.3
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150225/c942a75e/attachment.html>