[Mesa-dev] [PATCH] gallium/util: Define ffsll on OpenBSD.

[Matt Turner]

On Wed, Feb 25, 2015 at 7:03 PM, Jonathan Gray <jsg at jsg.id.au> wrote:
> On Wed, Feb 25, 2015 at 06:53:14PM -0800, Matt Turner wrote:
>> On Wed, Feb 25, 2015 at 5:37 PM, Jonathan Gray <jsg at jsg.id.au> wrote:
>> > If it isn't going to be configure checks could someone merge the
>> > original patch in this thread?
>>
>> I committed
>>
>> commit 3492e88090d2d0c0bfbc934963b8772b45fc8880
>> Author: Matt Turner <mattst88 at gmail.com>
>> Date:   Fri Feb 20 18:46:43 2015 -0800
>>
>>     gallium/util: Use HAVE___BUILTIN_* macros.
>>
>>     Reviewed-by: Eric Anholt <eric at anholt.net>
>>     Reviewed-by: Jose Fonseca <jfonseca at vmware.com>
>>
>> which switched over a bunch of preprocessor checks around __builtin*
>> calls to use the macros defined by autotools.
>>
>> So I think cleaning it up to use __builtin_ffs* first #ifdef
>> HAVE___BUILTIN_* can go forward now.
>
> Yes but there is no HAVE_FFSLL for constructs like
>
> #if !defined(HAVE_FFSLL) && defined(HAVE___BUILTIN_FFSLL)
>
> or is it ok to always use the builtin?

I think the question is whether it's okay to always use the builtin if
it's available (as opposed to libc functions). I think the answer to
that is yes.