[Mesa-dev] [PATCH 02/10] mesa: remove M_PI, M_E, M_LOG2E macro definitions
brianp at vmware.com
Thu Feb 26 07:39:15 PST 2015
On 02/26/2015 05:07 AM, Jose Fonseca wrote:
> On 26/02/15 09:19, Erik Faye-Lund wrote:
>> On Thu, Feb 26, 2015 at 10:10 AM, Erik Faye-Lund <kusmabite at gmail.com>
>>> On Thu, Feb 26, 2015 at 4:24 AM, Matt Turner <mattst88 at gmail.com> wrote:
>>>> On Wed, Feb 25, 2015 at 5:29 PM, Brian Paul <brianp at vmware.com> wrote:
>>>>> Should be defined in math.h. If not, we can add them to c99_math.h
>>>> And FWIW, the MSDN page  says that if you define _USE_MATH_DEFINES
>>>> before including math.h, these will be defined for you. Not sure what
>>>> versions of MSVC that applies to.
>>> That link says "Visual Studio 2013", but roughly the same message is
>>> also in the Visual Studio .NET 2003 docs (available through the "Other
>>> Versions"-selector at the top).
>>> IIRC, this has been the case since VC6, but we probably don't care
>>> about that old toolchains.
>> By the way, it seems we already define _USE_MATH_DEFINES, at least here:
>> But do we always build for MSVC with SCons, and with gallium? If so,
>> it seems this patch is OK from a MSVC's point of view.
> That's right. _USE_MATH_DEFINES should be always defined on MSVC.
> We could add
> #if defined(_MSC_VER) && !defined(_USE_MATH_DEFINES)
> #error _USE_MATH_DEFINES define required when building with MSVC
In c99_math.h? I can write a patch for that.
> To make this explicit. Actually defining _USE_MATH_DEFINES in the
> headers is hopeless, because the .c file might have included math.h
> before, so it can be too late. It must be passed to cl.exe to be 100%
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
More information about the mesa-dev