[Mesa-dev] [PATCH 2/2] i965/skl: [SQUASH] Update the MCS buffer scale sizes

Ben Widawsky ben at bwidawsk.net
Thu Feb 26 15:46:33 PST 2015


On Thu, Feb 26, 2015 at 03:42:53PM -0800, Ben Widawsky wrote:
> Keep this as a separate patch for review, but I will squash it with the previous
> patch before pushing.
> 
> We don't support 16x MSAA yet, but I entered it in here while I was at the
> table.
> 
> I'm having trouble getting through a piglit run on SKL at the moment, so I just
> few a threw small tests at it:
> 
> tests/fast_color_clear/all-colors.shader_test
> tests/fast_color_clear/non-redundant-clear.shader_test
> tests/fast_color_clear/redundant-clear.shader_test
> tests/fast_color_clear/fast-slow-clear-interaction.shader_test
> 
> Cc: Kristian Høgsberg <krh at bitplanet.net>
> Signed-off-by: Ben Widawsky <ben at bwidawsk.net>
> ---
>  src/gallium/drivers/ilo/ilo_layout.c            |  5 ++++-
>  src/mesa/drivers/dri/i965/brw_meta_fast_clear.c |  2 ++
>  src/mesa/drivers/dri/i965/intel_mipmap_tree.c   | 11 +++++++++--
>  3 files changed, 15 insertions(+), 3 deletions(-)
> 
> diff --git a/src/gallium/drivers/ilo/ilo_layout.c b/src/gallium/drivers/ilo/ilo_layout.c
> index 0b639b2..c2c8ec5 100644
> --- a/src/gallium/drivers/ilo/ilo_layout.c
> +++ b/src/gallium/drivers/ilo/ilo_layout.c
> @@ -1257,7 +1257,10 @@ layout_calculate_mcs_size(struct ilo_layout *layout,
>           break;
>        case INTEL_TILING_Y:
>           downscale_x = 32 / layout->block_size;
> -         downscale_y = 4;
> +         if (brw->gen >= 9)
> +            downscale_y = 2;
> +         else
> +            downscale_y = 4;
>           break;
>        default:
>           assert(!"unsupported tiling mode");

I didn't mean to fix ILO. I'll remove this hunk.
[snip]




More information about the mesa-dev mailing list