[Mesa-dev] [PATCH 3/3] radeonsi/compute: Enable PIPE_SHADER_CAP_DOUBLES

Marek Olšák maraeo at gmail.com
Fri Feb 27 07:34:08 PST 2015


Hi Kai,

The patch only enables double support for compute shaders, which don't use TGSI.

There is no TGSI double support in radeonsi yet, so
ARB_gpu_shader_fp64 can't be marked as done.

Marek

On Fri, Feb 27, 2015 at 1:38 PM, Kai Wasserbäch
<kai at dev.carbon-project.org> wrote:
> Should GL_ARB_gpu_shader_fp64 be marked as done for radeonsi in GL3.txt then? Or
> is PIPE_SHADER_CAP_TGSI_DROUND_SUPPORTED a must as well (I don't think so and
> maybe PIPE_SHADER_CAP_TGSI_DROUND_SUPPORTED could be enabled as well?).
>
> Cheers,
> Kai
>
>
> Tom Stellard wrote on 27.02.2015 02:06:
>> ---
>>  src/gallium/drivers/radeonsi/si_pipe.c | 7 +++++--
>>  1 file changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/drivers/radeonsi/si_pipe.c
>> index 26182c2..c7a7622 100644
>> --- a/src/gallium/drivers/radeonsi/si_pipe.c
>> +++ b/src/gallium/drivers/radeonsi/si_pipe.c
>> @@ -360,8 +360,11 @@ static int si_get_shader_param(struct pipe_screen* pscreen, unsigned shader, enu
>>                       return PIPE_SHADER_IR_NATIVE;
>>  #endif
>>               case PIPE_SHADER_CAP_DOUBLES:
>> -                     return 0; /* XXX: Enable doubles once the compiler can
>> -                                  handle them. */
>> +#if HAVE_LLVM >= 0x0307
>> +                     return 1;
>> +#else
>> +                     return 0;
>> +#endif
>>               case PIPE_SHADER_CAP_MAX_CONST_BUFFER_SIZE: {
>>                       uint64_t max_const_buffer_size;
>>                       pscreen->get_compute_param(pscreen,
>>
>
> --
>
> Kai Wasserbäch (Kai Wasserbaech)
>
> E-Mail: kai at dev.carbon-project.org
>
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>


More information about the mesa-dev mailing list