[Mesa-dev] [RFC] configure.ac: Don't check for python mako module if python is not installed

Matt Turner mattst88 at gmail.com
Fri Feb 27 09:42:32 PST 2015


On Fri, Feb 27, 2015 at 7:27 AM, Samuel Iglesias Gonsalvez
<siglesias at igalia.com> wrote:
> This could be the case of trying to compile a Mesa tarball (from 'make dist'
> command) in a machine without Python interpreter installed. The autogenerated
> files from mako templates were already created during tarball
> generation.
>
> In case of building from git without Python it is going to fail anyway because
> Python is not present when trying to autogenerate the files from mako
> templates.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89328
>
> Signed-off-by: Samuel Iglesias Gonsalvez <siglesias at igalia.com>
> ---
>  configure.ac | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/configure.ac b/configure.ac
> index 22dc023..a4e6338 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -114,7 +114,12 @@ if test "x$INDENT" != "xcat"; then
>      fi
>  fi
>
> -AX_CHECK_PYTHON_MAKO_MODULE(0.3.4)
> +if test -n "$PYTHON2"; then
> +    AX_CHECK_PYTHON_MAKO_MODULE(0.3.4)
> +else
> +    AC_MSG_WARN([python not found - unable to check for python mako module])
> +fi
> +

For flex and bison, we check if a generated source file exists, which
is probably a good idea. That way configure will fail in a git
checkout if you don't have python.

I have in my todo list to add some remaining source files generated by
python to the autotools distribution. After we commit some version of
this patch, Emil or I should make sure that all the python-generated
code is included in the tarball.


More information about the mesa-dev mailing list