[Mesa-dev] [PATCH] i965/skl: Fix the maximum thread count format for the PS
neil at linux.intel.com
Fri Feb 27 11:20:37 PST 2015
According to the bspec for some reason the format of the maximum
number of threads field has changed from U8-2 to U8-1 for the PS.
I've run this through Piglit and it doesn't cause any regressions.
src/mesa/drivers/dri/i965/gen8_ps_state.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/src/mesa/drivers/dri/i965/gen8_ps_state.c b/src/mesa/drivers/dri/i965/gen8_ps_state.c
index d4a58e4..5f39e12 100644
@@ -146,8 +146,13 @@ upload_ps_state(struct brw_context *brw)
/* 3DSTATE_PS expects the number of threads per PSD, which is always 64;
* it implicitly scales for different GT levels (which have some # of PSDs).
+ * In Gen8 the format is U8-2 whereas in Gen9 it is U8-1.
- dw6 |= (64 - 2) << HSW_PS_MAX_THREADS_SHIFT;
+ if (brw->gen >= 9)
+ dw6 |= (64 - 1) << HSW_PS_MAX_THREADS_SHIFT;
+ dw6 |= (64 - 2) << HSW_PS_MAX_THREADS_SHIFT;
if (prog_data->base.nr_params > 0)
dw6 |= GEN7_PS_PUSH_CONSTANT_ENABLE;
More information about the mesa-dev