[Mesa-dev] [Mesa-stable] [PATCH 1/3] i965/vec4: Fix implementation of i2b.

Ian Romanick idr at freedesktop.org
Fri Feb 27 13:15:37 PST 2015


This patch is

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

On 02/27/2015 11:34 AM, Matt Turner wrote:
> I broke this in commit 2881b123d. I must have misread i2b as b2i.
> 
> Cc: 10.5 <mesa-stable at lists.freedesktop.org>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=88246
> ---
>  src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp b/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp
> index f6f589d..0e30772 100644
> --- a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp
> @@ -1655,7 +1655,7 @@ vec4_visitor::visit(ir_expression *ir)
>        emit(CMP(result_dst, op[0], src_reg(0.0f), BRW_CONDITIONAL_NZ));
>        break;
>     case ir_unop_i2b:
> -      emit(AND(result_dst, op[0], src_reg(1)));
> +      emit(CMP(result_dst, op[0], src_reg(0), BRW_CONDITIONAL_NZ));
>        break;
>  
>     case ir_unop_trunc:
> 



More information about the mesa-dev mailing list