[Mesa-dev] [PATCH 0/6] egl: Drop non-c99 keywords - INLINE, __FUNCTION__

Brian Paul brianp at vmware.com
Sat Feb 28 12:20:21 PST 2015


On 02/28/2015 10:48 AM, Emil Velikov wrote:
> Here is to another round of cleanups :-)
>
> Namely we drop the use and definition of INLINE, __FUNCTION__ and use
> their c99 brothers.
>
> Patch 3 hides the internal _egl* symbols, which is no longer needed
> since we disabled st/egl. We might want to have this patch in 10.5 but
> I won't push on it.
>
> With the last two patches we directly include stdint.h where needed and
> drop the workaround/typecasts for non c99 compilers.
>
> Note: I did not notice any regression with the series for both automake
> and scons, yet the latter build of libEGL is broken * for me on master.
>
> * Library has unresolved/undefined symbols.
>
>
> Any additional testing would be appreciated. Series can be found in
> branch egl-c99-cleanup at https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_evelikov_Mesa_&d=AwIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=T0t4QG7chq2ZwJo6wilkFznRSFy-8uDKartPGbomVj8&m=5AwTKH7m3N3qjutRrxaUH_i60V8B_v8k8BlE5JyDIoQ&s=YKg7sFdmdC7VRFbFtTsz46moZjDVrPLIm0wrb8dWtns&e=

I didn't test it, but all the changes look good to me.

Reviewed-by: Brian Paul <brianp at vmware.com>



More information about the mesa-dev mailing list