[Mesa-dev] [PATCH] i965: Consider scratch writes to have side effects.

Jason Ekstrand jason at jlekstrand.net
Sat Feb 28 16:59:02 PST 2015


Yeah, this is probably good enough for now.

Reviewed-by: Jason Ekstrand <jason.ekstrand at intel.com>
On Feb 28, 2015 1:42 PM, "Matt Turner" <mattst88 at gmail.com> wrote:

> We could do better by tracking scratch reads and writes.
>
> Cc: 10.5 <mesa-stable at lists.freedesktop.org>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=88793
> ---
>  src/mesa/drivers/dri/i965/brw_shader.cpp | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_shader.cpp
> b/src/mesa/drivers/dri/i965/brw_shader.cpp
> index fbb20bc..ec3cfcb 100644
> --- a/src/mesa/drivers/dri/i965/brw_shader.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_shader.cpp
> @@ -963,6 +963,7 @@ backend_instruction::has_side_effects() const
>  {
>     switch (opcode) {
>     case SHADER_OPCODE_UNTYPED_ATOMIC:
> +   case SHADER_OPCODE_GEN4_SCRATCH_WRITE:
>     case SHADER_OPCODE_URB_WRITE_SIMD8:
>     case FS_OPCODE_FB_WRITE:
>        return true;
> --
> 2.0.5
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150228/5a03ba92/attachment.html>


More information about the mesa-dev mailing list