[Mesa-dev] [PATCH] i965: Implement WaCsStallAtEveryFourthPipecontrol on IVB/BYT.

Kenneth Graunke kenneth at whitecape.org
Sun Jan 4 17:27:06 PST 2015


On Sunday, January 04, 2015 12:03:01 PM Ben Widawsky wrote:
> On Wed, Nov 12, 2014 at 11:17:55AM -0800, Kenneth Graunke wrote:
> > According to the documentation, we need to do a CS stall on every fourth
> > PIPE_CONTROL command to avoid GPU hangs.  The kernel does a CS stall
> > between batches, so we only need to count the PIPE_CONTROLs in our batches.
> > 
> > v2: Get the generation check right (caught by Chris Wilson),
> >     combine the ++ with the check (suggested by Daniel Vetter).
> > 
> > Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> > Reviewed-by: Daniel Vetter <daniel.vetter at ffwll.ch>
> 
> Ken, did you want to push this patch?
> 
> [snip]

Yup, thanks.  There was some debate about whether IVB, BYT, or HSW needed it.
We found pretty convincing documentation that IVB needs it but HSW does not.

We also found documentation saying "VLV" needs it (but not VLVT?), but with
all the renaming of abbreviations, I'm inclined to assume the worst and apply
the workaround.

Pushed:

To ssh://git.freedesktop.org/git/mesa/mesa
   3793a1b..d41cf9f  master -> master
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150104/09099694/attachment.sig>


More information about the mesa-dev mailing list