[Mesa-dev] [RFC PATCH 28/40] i965/fs: Append uniform variables to the gather table

[Kenneth Graunke]

On Sunday, January 04, 2015 04:04:42 PM Abdiel Janulgue wrote:
> Signed-off-by: Abdiel Janulgue <abdiel.janulgue at linux.intel.com>
> ---
>  src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp b/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp
> index bd9345e..2f592c9 100644
> --- a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp
> @@ -180,6 +180,7 @@ fs_visitor::visit(ir_variable *ir)
>        reg = new(this->mem_ctx) fs_reg(UNIFORM, param_index);
>        reg->type = brw_type_for_base_type(ir->type);
>  
> +      stage_prog_data->gather_table[stage_prog_data->nr_gather_table++].reg = reg->reg;
>     } else if (ir->data.mode == ir_var_system_value) {
>        switch (ir->data.location) {
>        case SYSTEM_VALUE_BASE_VERTEX:
> 

For v2...please squash the FS and Vec4 patches which do the same thing into a
single logical patch.

It's hard to review 40 patches where many of them only add one line - it
becomes difficult to see the big picture or where things are going.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150104/a98f0926/attachment.sig>