[Mesa-dev] [PATCH 3/4] vc4: Drop the content of vc4_flush_resource().

[Michel Dänzer]

On 27.12.2014 03:45, Eric Anholt wrote:
> The callers all follow it with a flush of the context, and the flush of
> the context gives us more information about how things are being flushed.
> ---
>  src/gallium/drivers/vc4/vc4_resource.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/src/gallium/drivers/vc4/vc4_resource.c b/src/gallium/drivers/vc4/vc4_resource.c
> index df4c207..a26b346 100644
> --- a/src/gallium/drivers/vc4/vc4_resource.c
> +++ b/src/gallium/drivers/vc4/vc4_resource.c
> @@ -434,11 +434,11 @@ vc4_surface_destroy(struct pipe_context *pctx, struct pipe_surface *psurf)
>  static void
>  vc4_flush_resource(struct pipe_context *pctx, struct pipe_resource *resource)
>  {
> -        struct vc4_context *vc4 = vc4_context(pctx);
> -
> -        /* XXX: Skip this if we don't have any queued drawing to it. */
> -        vc4->base.flush(pctx, NULL, 0);
> +        /* All calls to flush_resource are followed by a flush of the context,
> +         * so there's nothing to do.
> +         */

The flush_resource callback is for flushing the *resource* for external
usage (e.g. resolving it after a fast clear, or uncompressing it), not
the context. So the new comment doesn't make sense.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer