[Mesa-dev] [PATCH 16/53] st/nine: Rework of boolean constants

[Ilia Mirkin]

On Wed, Jan 7, 2015 at 5:24 PM, Axel Davy <axel.davy at ens.fr> wrote:
> On 07/01/2015 18:23, Ilia Mirkin wrote :
>>
>> On Wed, Jan 7, 2015 at 11:36 AM, Axel Davy <axel.davy at ens.fr> wrote:
>>>
>>> Convert them to shader booleans at earlier stage
>>
>> Why? What's wrong with the conversion as it is now?
>
> The conversion is fine for booleans, but not for integers.
> I think it is cleaner to have both boolean and integers filled
> right away as right format. The next patch fixes the conversion
> for integers. It is possible if this patch doesn't fit for 10.4
> to put only the next one, but with vs_integer and ps_integer definitions
> added.

Meh... it's fine to backport, but the justification needs to be better
than "convert them earlier for no good reason at all", which was your
original commit message.