[Mesa-dev] [PATCH] mesa: Fix render buffer initial internal format type

michael.w.mason at intel.com michael.w.mason at intel.com
Fri Jan 9 17:21:01 PST 2015


From: Mike Mason <michael.w.mason at intel.com>

Changes the initial internal format of a render buffer
to GL_RGBA4. This fixes a failure in the following
DrawElements test:

dEQP-GLES3.functional.state_query.rbo.renderbuffer_internal_format
---
 src/mesa/main/renderbuffer.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/mesa/main/renderbuffer.c b/src/mesa/main/renderbuffer.c
index 0bc7f2b..b339491 100644
--- a/src/mesa/main/renderbuffer.c
+++ b/src/mesa/main/renderbuffer.c
@@ -53,7 +53,11 @@ _mesa_init_renderbuffer(struct gl_renderbuffer *rb, GLuint name)
    rb->Width = 0;
    rb->Height = 0;
    rb->Depth = 0;
-   rb->InternalFormat = GL_RGBA;
+   /* Default internal format should be GL_RGBA4, per page 258,
+    * table 6.15 of the GLES 3.0.4 spec. Same default is expected
+    * in all OpenGL specs that support BindRenderbuffer().
+    */
+   rb->InternalFormat = GL_RGBA4;
    rb->Format = MESA_FORMAT_NONE;
 }
 
-- 
1.9.1



More information about the mesa-dev mailing list