[Mesa-dev] [Bug 87516] glProgramBinary violates spec

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=87516

Ian Romanick <idr at freedesktop.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Ian Romanick <idr at freedesktop.org> ---
Fixed by the following commits on Mesa master.  Once there is some feedback
from Khronos on the spec bug, I'll post some updates.

commit f591712efeb9a757379d1e89907e2147749aaf6c
Author: Ian Romanick <ian.d.romanick at intel.com>
Date:   Sun Dec 21 12:06:23 2014 -0800

    mesa: Always generate GL_INVALID_OPERATION in _mesa_GetProgramBinary

    There are no binary formats supported, so what are you doing?  At least
    this gives the application developer some feedback about what's going
    on.  The spec gives no guidance about what to do in this scenario.

    Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=87516
    Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
    Acked-by: Leight Bade <leith at mapbox.com>

commit 4fd8b3012371a5795a0d272928266c6237e57466
Author: Ian Romanick <ian.d.romanick at intel.com>
Date:   Sun Dec 21 12:03:57 2014 -0800

    mesa: Ensure that length is set to zero in _mesa_GetProgramBinary

    v2: Fix assignment of length.  Noticed by Julien Cristau.

    Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=87516
    Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
    Acked-by: Leight Bade <leith at mapbox.com>

commit 201b9c181825551559f6d995007de8ff12d1a54c
Author: Ian Romanick <ian.d.romanick at intel.com>
Date:   Sun Dec 21 12:03:09 2014 -0800

    mesa: Add missing error checks in _mesa_ProgramBinary

    Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=87516
    Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
    Acked-by: Leight Bade <leith at mapbox.com>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150111/930b675f/attachment.html>