[Mesa-dev] No rule to make target ...format_pack.c (Was: [PATCH v4 00/22] auto-generate pack/unpack functions)

Mon Jan 12 04:48:20 PST 2015

On 12/01/15 12:32, Iago Toral Quiroga wrote:
> Hi Jose,
>
> thanks for reporting this.
>
> On lun, 2015-01-12 at 12:18 +0000, Jose Fonseca wrote:
>> Iago, Jason,
>>
>> There seems to be some bad or missing dependency when building with
>> automake.  I have a build bot that roughly does this every time:
>>
>>     git clean -fdx

Sorry.  This was wrong -- my build machine actually was _not_ wiping the 
build directory (I had commented that line) -- which means that the bug 
depends on previous build state, hence it will probably be a tad 
difficult to repro...

Furthermore I wiped the build dir and the issue doesn't indeed manifest 
from clean builds.

I think it's probably not worth pursue this further until somebody 
manages to get a good repro.

Jose

>>     mkdir -p build
>>     cd build
>>     ../autogen.sh --prefix=/usr --enable-debug --enable-dri3
>> --enable-gles1 --enable-gles2 --enable-xa --enable-nine --disable-opencl
>> --disable-vdpau --enable-shared-glapi --enable-gallium-llvm
>> --disable-llvm-shared-libs
>
> I have just tried these steps (only with --disable-dri3) and it seems to
> compile format_pack.c without problems... it fails later on because I
> don't have the required radeon libs, but libmesa and libmesagallium
> build fine for me.
>
> Samuel, can you reproduce the problem?
>
>> And it started failing:
>>
>>     make[4]: *** No rule to make target
>> `../../../src/mesa/main/format_pack.c', needed by `format_pack.lo'. Stop.
>>
>> Not sure of the problem here is triggered by the wiping the whole
>> source, or the building out of the source dir.
>>
>> It doesn't affect me much (as most of my testing depends on SCons build)
>> but this probably needs to be looked at.  Let me know if you prefer I
>> file a bug to track this.
>>
>> Jose
>>
>>
>> On 08/01/15 07:20, Iago Toral Quiroga wrote:
>>> This is the first of two series that aim to address:
>>> https://urldefense.proofpoint.com/v2/url?u=https-3A__bugs.freedesktop.org_show-5Fbug.cgi-3Fid-3D84566&d=AwIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=zfmBZnnVGHeYde45pMKNnVyzeaZbdIqVLprmZCM2zzE&m=D9XcoMD6m3_qVTyD7OqndEaqmB6eDSHjYd76sFDGBkA&s=gqJ3tbVTEA_LS4nw1a9PWqOFN7q5UJXoQOEgp3uBS0U&e=
>>>
>>> A branch with this series is available here:
>>> https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Igalia_mesa_tree_itoral-2Dautogen-2Dpacking-2Dreview-2Dv4&d=AwIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=zfmBZnnVGHeYde45pMKNnVyzeaZbdIqVLprmZCM2zzE&m=D9XcoMD6m3_qVTyD7OqndEaqmB6eDSHjYd76sFDGBkA&s=KX0x3bOmv8Pb19mCLDbWa-Mb1KJwu0Z3a8rHAPKyy64&e=
>>>
>>> Links to previous versions of the series:
>>> v3: https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.freedesktop.org_archives_mesa-2Ddev_2014-2DDecember_072274.html&d=AwIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=zfmBZnnVGHeYde45pMKNnVyzeaZbdIqVLprmZCM2zzE&m=D9XcoMD6m3_qVTyD7OqndEaqmB6eDSHjYd76sFDGBkA&s=SOzIkO8dgREs4cJNXIhZvr_pt1vPCoBLZFgEwdnKF04&e=
>>> v2: https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.freedesktop.org_archives_mesa-2Ddev_2014-2DDecember_071622.html&d=AwIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=zfmBZnnVGHeYde45pMKNnVyzeaZbdIqVLprmZCM2zzE&m=D9XcoMD6m3_qVTyD7OqndEaqmB6eDSHjYd76sFDGBkA&s=0wOx9fh_9yqFYSo8IhZFlyVbOyFArdb5U1jBVmkdAoA&e=
>>> v1: https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.freedesktop.org_archives_mesa-2Ddev_2014-2DNovember_070898.html&d=AwIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=zfmBZnnVGHeYde45pMKNnVyzeaZbdIqVLprmZCM2zzE&m=D9XcoMD6m3_qVTyD7OqndEaqmB6eDSHjYd76sFDGBkA&s=vUxqaafxwTFioVZcqQtEnWt_RMb-oQK-89-gmZ30Z74&e=
>>>
>>> Tested on i965, classic swrast and gallium (radeon, nouveau, llvmpipe) without
>>> regressions.
>>>
>>> Patches that need review: 2, 8, 12-15, 17
>>>     - Patches 2 and 12 were originally written by Jason, so I guess we want
>>>       somebody else to review these besides him.
>>>     - Patches 14-15 were also originally written by Jason, but they have gone
>>>       through plenty of changes so maybe it is okay if only Jason reviews them.
>>>
>>> Iago Toral Quiroga (3):
>>>     mesa: Fix incorrect assertion in init_teximage_fields_ms
>>>     swrast: Remove unused variable.
>>>     mesa: Let _mesa_get_format_base_format also handle mesa_array_format.
>>>
>>> Jason Ekstrand (9):
>>>     mesa: Fix clamping to -1.0 in snorm_to_float
>>>     mesa: Fix packing/unpacking of MESA_FORMAT_R5G6B5_UNORM
>>>     mesa/colormac: Remove an unused macro
>>>     mesa: Fix A1R5G5B5 packing/unpacking
>>>     mesa/format_utils: Prefix and expose the conversion helper functions
>>>     main: Add a concept of an array format
>>>     mesa: Add a _mesa_is_format_color_format helper
>>>     mesa: Autogenerate most of format_pack.c
>>>     mesa: Autogenerate format_unpack.c
>>>
>>> Samuel Iglesias Gonsalvez (10):
>>>     mesa: Fix get_texbuffer_format().
>>>     mesa: Fix _mesa_swizzle_and_convert integer conversions to clamp
>>>       properly
>>>     configure: require python mako module
>>>     mesa: Add _mesa_pack_uint_rgba_row() format conversion function
>>>     mesa/format_pack: Add _mesa_pack_int_rgba_row()
>>>     mesa/formats: add new mesa formats and their pack/unpack functions.
>>>     mesa: use format conversion functions in swrast
>>>     mesa/pack: use autogenerated format_pack functions
>>>     mesa/main/pack_tmp.h: Add float conversion support
>>>     mesa/pack: refactor _mesa_pack_rgba_span_float()
>>>
>>>    configure.ac                      |    2 +
>>>    docs/install.html                 |    6 +-
>>>    m4/ax_check_python_mako_module.m4 |   61 +
>>>    src/mesa/Makefile.am              |   18 +
>>>    src/mesa/Makefile.sources         |    6 +-
>>>    src/mesa/SConscript               |   14 +
>>>    src/mesa/main/.gitignore          |    2 +
>>>    src/mesa/main/colormac.h          |    3 -
>>>    src/mesa/main/format_info.py      |   16 +
>>>    src/mesa/main/format_pack.c       | 2994 -------------------------
>>>    src/mesa/main/format_pack.h       |    6 +
>>>    src/mesa/main/format_pack.py      | 1124 ++++++++++
>>>    src/mesa/main/format_parser.py    |   47 +
>>>    src/mesa/main/format_unpack.c     | 4400 -------------------------------------
>>>    src/mesa/main/format_unpack.py    |  895 ++++++++
>>>    src/mesa/main/format_utils.c      |  302 +--
>>>    src/mesa/main/format_utils.h      |  165 ++
>>>    src/mesa/main/formats.c           |  271 ++-
>>>    src/mesa/main/formats.csv         |   13 +
>>>    src/mesa/main/formats.h           |  156 +-
>>>    src/mesa/main/pack.c              | 2111 +++---------------
>>>    src/mesa/main/pack_tmp.h          |   76 +-
>>>    src/mesa/main/teximage.c          |    6 +-
>>>    src/mesa/main/texstore.c          |    2 +-
>>>    src/mesa/swrast/s_drawpix.c       |    3 -
>>>    src/mesa/swrast/s_texfetch.c      |   13 +
>>>    src/mesa/swrast/s_texfetch_tmp.h  | 1359 +-----------
>>>    27 files changed, 3443 insertions(+), 10628 deletions(-)
>>>    create mode 100644 m4/ax_check_python_mako_module.m4
>>>    delete mode 100644 src/mesa/main/format_pack.c
>>>    create mode 100644 src/mesa/main/format_pack.py
>>>    delete mode 100644 src/mesa/main/format_unpack.c
>>>    create mode 100644 src/mesa/main/format_unpack.py
>>>
>>
>>
>
>