[Mesa-dev] [PATCH v3] mesa: Enable GL_RGB/GL_RGBA in GLES3 glGetInternalformativ

Chad Versace chad.versace at intel.com
Tue Jan 13 11:28:01 PST 2015


On 01/13/2015 11:12 AM, Matt Turner wrote:
> On Tue, Jan 13, 2015 at 10:49 AM, Chad Versace <chad.versace at intel.com> wrote:
>> On 01/12/2015 02:37 PM, michael.w.mason at intel.com wrote:
>>> From: Mike Mason <michael.w.mason at intel.com>
>>>
>>> Removes commit 7894278 changes and moves fix to _mesa_GetInternalformativ().
>>> The original commit enabled the GL_RGB and GL_RGBA unsized internal formats
>>> as valid for render buffers in GLES3, but this is incorrect. They should
>>> have only been enabled for GetInternalformativ()
>>>
>>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=88079
>>> ---
>>>  src/mesa/main/fbobject.c    |  6 ------
>>>  src/mesa/main/formatquery.c | 16 +++++++++++++++-
>>>  2 files changed, 15 insertions(+), 7 deletions(-)
>>
>> Reviewed-by: Chad Versace <chad.versace at intel.com>
>>
>> Matt commented on v1, so let's wait for his comments on this version too
>> before committing the patch.
>>
> 
> Looks good to me!
> 
> Reviewed-by: Matt Turner <mattst88 at gmail.com>

Committed.



More information about the mesa-dev mailing list