[Mesa-dev] [PATCH v4] mesa/glsl/glapi: enable GL_EXT_draw_buffers extension

[Chad Versace]

On 01/13/2015 09:46 AM, Matt Turner wrote:
> On Mon, Jan 12, 2015 at 9:54 PM, Tapani Pälli <tapani.palli at intel.com> wrote:
>> Patch enables ES2 extension that utilizes existing ES3 functionality.
>>
>> Changes make all the subtests to run and pass in WebGL conformance
>> test 'webgl-draw-buffers' when running Chrome on OpenGL ES, also
>> Piglit test 'draw_buffers_gles2' passes.
>>
>> v2: remove unused boolean (Ilia Mirkin)
>> v3: proper error checking for invalid values (Chad Versace)
>> v4: run error check explicitly for ES2 and ES3 (Kenneth Graunke)
>>
>> Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
>> ---
>>  src/glsl/glcpp/glcpp-parse.y    | 1 +
>>  src/glsl/glsl_parser_extras.cpp | 1 +
>>  src/glsl/glsl_parser_extras.h   | 2 ++
>>  src/mapi/glapi/gen/es_EXT.xml   | 9 +++++++++
>>  src/mesa/main/buffers.c         | 6 ++++--
>>  src/mesa/main/extensions.c      | 1 +
>>  6 files changed, 18 insertions(+), 2 deletions(-)



>> diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c
>> index 4fa9d1a..0d95eff 100644
>> --- a/src/mesa/main/extensions.c
>> +++ b/src/mesa/main/extensions.c
>> @@ -213,6 +213,7 @@ static const struct extension extension_table[] = {
>>     { "GL_EXT_compiled_vertex_array",               o(dummy_true),                              GLL,            1996 },
>>     { "GL_EXT_copy_texture",                        o(dummy_true),                              GLL,            1995 },
>>     { "GL_EXT_depth_bounds_test",                   o(EXT_depth_bounds_test),                   GL,             2002 },
>> +   { "GL_EXT_draw_buffers",                        o(dummy_true),                                          ES2, 2012 },
> 
> I know the other ES2 cases have misaligned the data column in this
> area, but that's because of the extra character in GLL. Remove a space
> before ES2 to align the date column, and have a
> 
> Reviewed-by: Matt Turner <mattst88 at gmail.com>

Me too.
Reviewed-by: Chad Versace <chad.versace at intel.com>


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 884 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150113/cc6485b6/attachment-0001.sig>