[Mesa-dev] [PATCH v3 05/10] formats: Use a hash table for _mesa_format_from_array_format

Kenneth Graunke kenneth at whitecape.org
Tue Jan 13 20:21:27 PST 2015


On Tuesday, January 13, 2015 08:02:54 PM Jason Ekstrand wrote:
> On Jan 13, 2015 6:38 PM, "Kenneth Graunke" <kenneth at whitecape.org> wrote:
> >
> > On Tuesday, January 13, 2015 10:28:20 AM Jason Ekstrand wrote:
> > > Going through the for loop every time has noticable overhead.  This
> fixes
> > > things up so we only do that once ever and then just do a hash table
> lookup
> > > which should be much cheaper.
> > > ---
> > >  src/mesa/main/formats.c | 67
> +++++++++++++++++++++++++++++++++++++++++--------
> > >  1 file changed, 56 insertions(+), 11 deletions(-)
> >
> > This will break Windows.
> 
> Why? We have a C++11-based  implementation of pthread_once.
> --Jason

I think you have to use call_once and "once_flag".  I don't see pthread_once
existing in threads_win32.h, only threads_posix.h, which doesn't appear to
be #included on windows.

--Ken
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150113/62e53725/attachment.sig>


More information about the mesa-dev mailing list