[Mesa-dev] [PATCH] i965: Remove extra irb->need_downsample = true from fast clear code.

Kenneth Graunke kenneth at whitecape.org
Wed Jan 14 08:54:16 PST 2015


In the common case, this is redundant - we set it a few lines later.

However, when irb->mt->fast_clear_state == INTEL_FAST_CLEAR_STATE_CLEAR,
this causes irb->need_downsample to be set, even though we skip altering
the buffer at all.  We don't want to do that.

Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
---
 src/mesa/drivers/dri/i965/brw_meta_fast_clear.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/mesa/drivers/dri/i965/brw_meta_fast_clear.c b/src/mesa/drivers/dri/i965/brw_meta_fast_clear.c
index c8f2a14..22c2a04 100644
--- a/src/mesa/drivers/dri/i965/brw_meta_fast_clear.c
+++ b/src/mesa/drivers/dri/i965/brw_meta_fast_clear.c
@@ -494,7 +494,6 @@ brw_meta_fast_clear(struct brw_context *brw, struct gl_framebuffer *fb,
       case FAST_CLEAR:
          irb->mt->fast_clear_color_value =
             compute_fast_clear_color_bits(&ctx->Color.ClearColor);
-         irb->need_downsample = true;
 
          /* If the buffer is already in INTEL_FAST_CLEAR_STATE_CLEAR, the
           * clear is redundant and can be skipped.  Only skip after we've
-- 
2.2.1



More information about the mesa-dev mailing list