[Mesa-dev] [PATCH] Revert "radeonsi: only set BC_OPTIMIZE_DISABLE when necessary"

[Michel Dänzer]

On 14.01.2015 20:22, Marek Olšák wrote:
> On Wed, Jan 14, 2015 at 3:33 AM, Michel Dänzer <michel at daenzer.net> wrote:
>> On 13.01.2015 19:11, Marek Olšák wrote:
>>> This is weird. We only enable this optimization if the shader code
>>> doesn't use CENTROID at all. This is the main flag:
>>> sctx->ps_shader->info.uses_centroid.
>>>
>>> You can try to simplify the condition to:
>>>
>>> bc_optimize_disable = sctx->ps_shader->info.uses_centroid;
>>>
>>> That should avoid using the optimization even for the non-MSAA case if
>>> CENTROID is used.
>>
>> That would probably fix the problem, but I wonder if the optimization
>> has any effect then? What little description I've found of it sounds
>> like it could only have an effect for shaders which use both centroid
>> and center interpolation.
> 
> I don't know. I couldn't find any useful info about it either.

Until we understand how it works, it's probably better to keep it disabled?


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer