[Mesa-dev] [PATCH] mesa: fix no return in two format functions

[Jan Vesely]

On Thu, 2015-01-15 at 19:26 +0100, Tobias Klausmann wrote:
> I: Program returns random data in a function
> E: Mesa no-return-in-nonvoid-function ../../src/mesa/main/format_utils.c:180
> E: Mesa no-return-in-nonvoid-function ../../src/mesa/main/glformats.c:2714

Are these errors generated by a compiler or some kind of analysis tool?
Does using unreachable() instead of assert(!) fix the problem?

jan

> ---
>  src/mesa/main/format_utils.c | 1 +
>  src/mesa/main/glformats.c    | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/src/mesa/main/format_utils.c b/src/mesa/main/format_utils.c
> index eb650a2..caf0880 100644
> --- a/src/mesa/main/format_utils.c
> +++ b/src/mesa/main/format_utils.c
> @@ -176,6 +176,7 @@ _mesa_compute_rgba2base2rgba_component_mapping(GLenum baseFormat, uint8_t *map)
>        }
>     default:
>        assert(!"Unexpected base format");
> +      return false;
>     }
>  }
>  
> diff --git a/src/mesa/main/glformats.c b/src/mesa/main/glformats.c
> index 3e913ed..2e16607 100644
> --- a/src/mesa/main/glformats.c
> +++ b/src/mesa/main/glformats.c
> @@ -2711,4 +2711,5 @@ _mesa_format_from_format_and_type(GLenum format, GLenum type)
>      * format in that case.
>      */
>     assert(!"Unsupported format");
> +   return MESA_FORMAT_NONE;
>  }

-- 
Jan Vesely <jan.vesely at rutgers.edu>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150115/6036ba4a/attachment.sig>