[Mesa-dev] [PATCH 4/4] i965/nir: Enable SIMD16 support in the NIR FS backend.

Kenneth Graunke kenneth at whitecape.org
Fri Jan 16 15:26:49 PST 2015


On Friday, January 16, 2015 02:43:12 PM Jason Ekstrand wrote:
> Two stupid questions:
> 
> 1) Did you gun piglit with INTEL_USE_NIR and did everything check out OK?

Yes, I did before/after Piglit runs on Haswell GT3e with and without
INTEL_USE_NIR (to make sure both paths keep working).

> 2) Did you grep fs_nir.cpp for virtual_grf_alloc and reg_offset to make
> sure you didn't miss anything?

I apparently missed a single virtual_grf_alloc in the interpolateAt code.
This only runs in SIMD8 anyway, so it didn't matter.  But, I changed it
in v3 just to be consistent.

> If the answer to both of the above is yes, this series is
> 
> Reviewed-by: Jason Ekstrand <jason.ekstrand at intel.com>

Thanks Jason!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150116/ea70bf60/attachment.sig>


More information about the mesa-dev mailing list