[Mesa-dev] [PATCH 01/22] glsl: Reorder optimization-passes

[Thomas Helland]

2015-01-03 22:48 GMT+01:00 Matt Turner <mattst88 at gmail.com>:
> On Sat, Jan 3, 2015 at 11:18 AM, Thomas Helland
> <thomashelland90 at gmail.com> wrote:
>> This allows opt_algebraic to resolve open-coded
>> saturates into ir_unop_saturate before we potentially
>> mess it up by removing the min or max in min/max-pruning.
>>
>> Since we are now emitting more free saturates on i965
>> this gives us some decrease in instruction count.
>>
>> total instructions in shared programs: 1317459 -> 1317065 (-0.03%)
>> instructions in affected programs:     4084 -> 3690 (-9.65%)
>> GAINED:                                0
>> LOST:                                  0
>
> You're definitely onto something here. On our collection of shaders:
>
> total instructions in shared programs: 5876617 -> 5875919 (-0.01%)
> instructions in affected programs:     9443 -> 8745 (-7.39%)
>
> with some fragment shaders hurt in Natural Selection 2 and Kerbal Space program.
>
> I'll investigate these.

Hi Matt,

Don't want to be a nuisance (if that is even the right word?
English is not my native tongue), but did you find the
time to look at these regressions?

If I had some information about what regressions you are
seeing I could try to work them out.
Then this patch would be merge-material I guess.

The rest of the series I'm not that happy about.
Seems to me the "return on investment" is not adequate.
But I'll leave that up to other people to decide.