[Mesa-dev] [PATCH 1/7] i965: Enable L3 caching of buffer surfaces.

Kenneth Graunke kenneth at whitecape.org
Sat Jan 17 15:21:43 PST 2015


On Sunday, January 18, 2015 01:04:03 AM Francisco Jerez wrote:
> And remove the mocs argument of the emit_buffer_surface_state vtbl hook.  Its
> semantics vary greatly from one generation to another, so it kind of
> encourages the caller to pass 0 which is the only valid setting across
> generations.  After this commit the hardware-specific code decides what the
> best cacheability settings are for buffer surfaces, just like we do for
> textures.
> 
> This together with some additional changes coming is expected to improve
> performance of pull constants, buffer textures, atomic counters and image
> objects on Gen7 and up.

Thanks!  I had a version of this lying around, but never measured any gain
from it, so I never bothered to send it.  I definitely like removing the
parameter, and we probably should set it - we do everywhere else...

This patch is:
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150117/dba5d0f0/attachment.sig>


More information about the mesa-dev mailing list